feat(admin-ui): Preset filters should preserve query parameters

[taxilian]

Description

Any page that uses data-table2 with presets, when the presets change they lose any query parameters. This includes the currently set "display per page". This can be very frustrating if you use presets to switch quickly between groups of items which number more than 10 because you have to keep moving down and turning it back up.

This fix causes it to keep any existing query parameters except the "filters" and "page" parameters, which are the ones that it uses.

Breaking changes

No, just changed behavior

Screenshots

Checklist

📌 Always:

• I have set a clear title
• My PR is small and contains a single feature
• I have checked my own PR

👍 Most of the time:

• I have added or updated test cases - Not applicable, AFAIK
• I have updated the README if needed - Not applicable, AFAIK

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	Nov 16, 2024 0:12am

[michaelbromley]

Hi!

This is a good improvement but it seems to not work reliably in all cases, according to my testing.

1. go to product list
2. create a filter preset (exact type does not matter)
3. navigate away from product list to another page
4. return to product list
5. set items per page to 25
6. click the preset

You will see that the "perPage" query param is lost.

This can be solved by adding this to the onInit() method:

        // When any query param changes, we want to trigger change detection
        // so that the links for each preset are updated.
        this.route.queryParamMap
            .pipe(takeUntil(this.destroy$))
            .subscribe(() => this.changeDetectorRef.markForCheck());

[taxilian]

pushed a fix; thanks for taking the time to look at and test this. It's really slowing down some of our workflows =]

My last real experience with Angular was about 6 years ago, so I'm beyond rusty dealign with rxjs nonsense. I'm more of a vue fan myself =]

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[michaelbromley]

Thank you, that works well now 👍