Docs: requireVerification=true does accept password
#2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
martijnvdbrug
commented
Jul 30, 2024
| * `password` property - doing so will result in an error. Instead, the password is set at a later stage | ||
| * (once the email with the verification token has been opened) via the `verifyCustomerAccount` mutation. | ||
| * If set to "true", the customer will be required to verify their email address using a verification token | ||
| * they receive in their email. See {@link registerCustomerAccount}. |
There was a problem hiding this comment.
Does this @link work when linking to a mutation?
There was a problem hiding this comment.
No, because the TS compiler does not know about the graphql schema.
There was a problem hiding this comment.
Ahh ok, I though it was a higher level tool that resolved these links on the docs website. Will remove it
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The requireVerification docs are conflicting with the registerCustomerAccount docs
Checklist
📌 Always:
👍 Most of the time: