Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 for docs search results #2957

Closed
martijnvdbrug opened this issue Jul 18, 2024 · 2 comments
Closed

404 for docs search results #2957

martijnvdbrug opened this issue Jul 18, 2024 · 2 comments
Labels
P3: minor Non-critical, no workarounds exist type: bug 🐛 Something isn't working

Comments

@martijnvdbrug
Copy link
Collaborator

Describe the bug
There are quite a few search results that lead to a 404 page.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://docs.vendure.io/
  2. Search for "Draft"
  3. Click the top result, it will lead you to https://docs.vendure.io/user-guide/orders/draft-orders/, which doesn't exists

I've come across quite a few of these, most of them in usser/-guide. I didn't keep track of all of them though...

image

Expected behavior
No 404's in the search results

@martijnvdbrug martijnvdbrug added type: bug 🐛 Something isn't working P3: minor Non-critical, no workarounds exist labels Jul 18, 2024
@michaelbromley
Copy link
Member

Ah good point. The "user guide" pages were not yet updated since we refreshed the Admin UI in v2. So that's long overdue. It looks like the Typesense scraper is picking them up from the sitemap.xml file.

Ultimate solution would be to actually update them and get them published.

For now there should be a way to exclude them from the scraping. The scraper config file is here: https://github.com/vendure-ecommerce/vendure/blob/3322a5633ea3215064a084d2c63993c22183812e/docs/scraper/config.json, and I think we could use the
stop_urls option to exclude those pages.

@michaelbromley
Copy link
Member

I restored the guides in this commit 2f2248c

They are still pretty sparse on info, but we can start improving them from here: https://docs.vendure.io/user-guide/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3: minor Non-critical, no workarounds exist type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants