Incorrect EntityId column types and missing foreign keys

[jacobfrantz1]

Describe the bug
There's weirdness related to EntityId() Columns that don't have a foreign key. They don't use the entityIdStrategy's primaryKeyType and use varchar instead. This led to problems when I was migrating to v2, which I documented in vendure-ecommerce/v2-migration-tool#9. I only found 2 EntityId Columns without a foreign key in the project. They are product_variant_price.channelId and order.taxZoneId.

Expected behavior
The two columns that use the EntityId decorator and don't have a foreign key should have a foreign key, and the code that incorrectly assumes the type as varchar should be corrected. We shouldn't rely on typeorm fixing foreign key types, which is what I think is occurring.

The code const columnDataType = entityIdStrategy.primaryKeyType === 'increment' ? 'int' : 'varchar'; in set-entity-id-strategy.ts should probably be const columnDataType = entityIdStrategy.primaryKeyType === 'increment' ? 'int' : entityIdStrategy.primaryKeyType;

This would be a breaking change for anybody using a primaryKeyType other than increment, and a migration would be required for it.

Environment:

• @vendure/core version: 2.0.4
• Nodejs version: 16.20.1
• Database (mysql/postgres etc): postgresql 14

[michaelbromley]

Hi,
thanks for the report. This would indeed be a breaking change but you are totally correct, we should use 'uuid' rather than 'varchar'.

I've added this to "planned" but I'm not sure yet when I want to make the change. Apart from the migration issue, did you run into any other problems due to the varchar data type?

[jacobfrantz1]

I didn't have any other problems due to the varchar data type that I know of.