price range should not include disabled product variant

[simpian]

Describe the bug
A clear and concise description of what the bug is.

When there are multiple product variant, different variant price, e.g.

color white - 10.99
color red - 14.99

price range is min: 10.99, max: 14.99

if color white is disabled, min should no longer be 10.99, should be 14.99 - 14.99

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Environment (please complete the following information):

• @vendure/core version: 1.5.0
• Nodejs version
• Database (mysql/postgres etc):

Additional context
Add any other context about the problem here.

[michaelbromley]

Hi, thanks for the report!
Can you be a bit more explicit with the reproduction? On first glance I am assuming that this is related to the search query? If you could include an example query which produces the bad result that would be helpful. It makes it easier for me to switch into the context of this issue when I come to deal with it 👍

[simpian]

Hope this helps

operationName: "SearchProducts"
query: "query SearchProducts($input: SearchInput!) {\n  search(input: $input) {\n    items {\n      productId\n      productName\n      productVariantId\n      productVariantName\n      collectionIds\n      inStock\n      productAsset {\n        preview\n        __typename\n      }\n      price {\n        ... on PriceRange {\n          min\n          max\n          __typename\n        }\n        __typename\n      }\n      priceWithTax {\n        ... on PriceRange {\n          min\n          max\n          __typename\n        }\n        __typename\n      }\n      customMappings {\n        ... on CustomProductVariantMappings {\n          limitPerOrder\n          __typename\n        }\n        ... on CustomProductMappings {\n          ranking\n          originalPrice\n          limitPerOrder\n          hasMultiVariant\n          createdAt\n          __typename\n        }\n        __typename\n      }\n      __typename\n    }\n    totalItems\n    __typename\n  }\n}\n"
variables: {input: {groupByProduct: true, term: "", collectionId: "", take: 8, skip: 0,…}}
input: {groupByProduct: true, term: "", collectionId: "", take: 8, skip: 0,…}
collectionId: ""
groupByProduct: true
skip: 0
sort: {inStock: "DESC", createdAt: "DESC", ranking: "DESC"}
createdAt: "DESC"
inStock: "DESC"
ranking: "DESC"
take: 8
term: ""

[michaelbromley]

Hi, I looked into this and cannot reproduce it successfully. Are you sure that the search index has been updated after disabling the variant?

issue-1482.mp4

[simpian]

I still have this issue, I'm wondering if it's because I have a custom search options, that may have overwritten your default filtering options?

[michaelbromley]

Are you using the DefaultSearchPlugin or ElasticsearchPlugin?

[martijnvdbrug]

@simpian Can you provide a minimal reproduction + versions + the search plugin you are using (Default, Elastic, or...)?