Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The admin ui "product edit" page missed copy content from default language "en" #1443

Open
tianyingchun opened this issue Feb 24, 2022 · 4 comments
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@tianyingchun
Copy link
Contributor

Describe the bug

  1. First we have default language "en" have some products
  2. at this time we need to create antoher locale "en_GB" in most case we need to copy all of contents from "en"
  3. it should contain "product name", "slug", "desctipton", "some customized fields" all of them need to copy from existed "en"
  4. and then change something and click "save"

To Reproduce

Now it missed all "translation" fields content . please see screen pictures

image

Expected behavior
A clear and concise description of what you expected to happen.

Environment (please complete the following information):

  • @vendure/core version: 1.4.7
  • Nodejs version 16+
  • Database (mysql/postgres etc): mysql

Additional context
Add any other context about the problem here.

@tianyingchun tianyingchun added the type: bug 🐛 Something isn't working label Feb 24, 2022
@michaelbromley
Copy link
Member

Hi @tianyingchun is this issue still current in the latest version?

@tianyingchun
Copy link
Contributor Author

yes, still missed copy content from default language "en"

@tianyingchun
Copy link
Contributor Author

en
image
slide to en_GB
image

@martijnvdbrug
Copy link
Collaborator

@michaelbromley Isn't this expected behavior? I would not expect my English descriptions to show up when switching to Dutch.

I like that the API resolves to English if there is no Dutch translation, but I would be confused as UI user if my Dutch description is in English. I'd expect it to be empty.

Or am I misunderstanding the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants