RewardsSugar: forRoot helper
#92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The new forRoot function looks good to me. It allows us to fetch the Root Gauge, Fees & Bribes contracts necessary for reward claiming.
The Gauge address will then be used on Leaf to fetch the Reward Token addresses required for claims, right?
This would unfortunately require at least an additional RPC call on Leaf, but given that reward token addresses are not stored on Root, this appears to be necessary (at least for the incentive token addresses).
correct Overall all concerns inline with the scope of this PR. Ty ty @airtoonricardo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with leaf -> root address translations.