Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups #89

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Cleanups #89

merged 3 commits into from
Oct 30, 2024

Conversation

stas
Copy link
Collaborator

@stas stas commented Oct 28, 2024

  • linter cleanups
  • refactored the safe calls due to revert_on_failure cancelling the success return value
  • unified tests to use CHAIN_ID env var

Gas estimates

v0.3.10

>>> lpold1 = LpSugar.at("0x51f290CCCD6a54Af00b38edDd59212dE068B8A4b")
>>> lpold1.forSwaps.estimate_gas(2000, 0, {'from': account})
42445612
>>> lpold1.all.estimate_gas(500, 0, {'from': account})
33651074
>>> lpold1.positions.estimate_gas(200, 0, account.address, {'from': account})
8531733
>>>

v0.4

>>> lp1 = LpSugar.at('0xd0bF8A2e7ECAC81106b3A1A341299E9314219598')
>>> lp1.forSwaps.estimate_gas(2000, 0, {'from': account})
22197632
>>> lp1.all.estimate_gas(500, 0, {'from': account})
34532068
>>> lp1.positions.estimate_gas(200, 0, account.address, {'from': account})
10043633

@stas stas force-pushed the cleanups branch 2 times, most recently from ca63d5c to d07986a Compare October 29, 2024 11:36
Copy link
Contributor

@pedrovalido pedrovalido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
really like these changes 🚀

(needs the ci fixed before merging)

@stas stas force-pushed the cleanups branch 3 times, most recently from a29c94d to 26cc942 Compare October 29, 2024 22:02
@stas stas merged commit 0860136 into positionsUnstaked Oct 30, 2024
4 of 8 checks passed
@stas stas deleted the cleanups branch October 30, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants