Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lp Module / RewardsSugar #87

Merged
merged 8 commits into from
Oct 30, 2024
Merged

Lp Module / RewardsSugar #87

merged 8 commits into from
Oct 30, 2024

Conversation

stas
Copy link
Collaborator

@stas stas commented Oct 26, 2024

LpSugar hit bytesize limits and had to be split:

  • lp_shared module was added
  • rewards related logic was moved into a separate contract

pedrovalido
pedrovalido approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@pedrovalido pedrovalido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just needs the ci fixed

@pedrovalido pedrovalido mentioned this pull request Oct 29, 2024
Closed
Base automatically changed from vyper-v0.4 to v3 October 30, 2024 13:40
@stas stas merged commit ee212af into v3 Oct 30, 2024
2 of 4 checks passed
@stas stas deleted the lp_module branch October 30, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrovalido pedrovalido pedrovalido approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stas @pedrovalido