Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that Fedex Request Base class adds authentication params to requests #3

Open
calvinhughes opened this issue Jul 19, 2019 · 0 comments
Open

Ensure that Fedex Request Base class adds authentication params to requests #3

calvinhughes opened this issue Jul 19, 2019 · 0 comments
Milestone
Refactoring plan

Comments

@calvinhughes
Copy link
Collaborator

Every single request type, we're adding the following XML nodes with these methods:

  • add_web_authentication_detail
  • add_client_detail
  • add_version

All of them inherit Fedex::Request::Base, so this can be the responsibility of that instance - therefore reducing duplication.
@calvinhughes calvinhughes added this to the Refactoring plan milestone Jul 19, 2019
@calvinhughes calvinhughes added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Jul 19, 2019
@calvinhughes calvinhughes mentioned this issue Jul 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Refactoring plan
Development

No branches or pull requests
1 participant
@calvinhughes