Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cabinets do not extend barrels #970

Open
Violet-Scarelli opened this issue Aug 23, 2024 · 2 comments
Open

Cabinets do not extend barrels #970

Violet-Scarelli opened this issue Aug 23, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Violet-Scarelli
Copy link

As the title says. This is a rather esoteric issue, but cabinets having their own unique code (instead of extending barrels) prevents them from being used as containers on Create contraptions, as well as being used by Botania's Corporea network. I'm not sure how trivial or difficult such a change would be, but making cabinets extend barrels would be extremely helpful.

@MehVahdJukaar
Copy link
Contributor

i think actual issue is that they dont provider item handler capability. In 1.21 one needs to manually register those as they are not gotten through inheritancy. extending wout both be incorrect, as cabinets are not barrel, nor solve the issue

@vectorwing vectorwing added the bug Something isn't working label Oct 2, 2024
@vectorwing
Copy link
Owner

I ran a quick test on this for both 1.20.1 and 1.21, and yeah, both versions seem affected by this.

While the 1.21 change makes sense, and requires me to implement it through a NeoForge event, I am unsure why it's not working on 1.20.1 yet. It uses the same overrides as BarrelBlockEntity, and both get properly cast to a common item handler, according to my breakpoints. 🤔

Not sure what to do about 1.20 yet, but at least I can test out a fix on 1.21 later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants