Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place Marker Offset ignored #13719

Open
riverwanderer opened this issue Nov 28, 2024 · 0 comments · May be fixed by #13720
Open

Place Marker Offset ignored #13719

riverwanderer opened this issue Nov 28, 2024 · 0 comments · May be fixed by #13720
Labels
bug Something isn't working

Comments

@riverwanderer
Copy link
Collaborator

riverwanderer commented Nov 28, 2024 •
edited
Loading

As described in this thread, a STACKABLE piece, when placed with the PLACE MARKER trait will ignore any offset specified by the trait.

It is apparent in PlaceMarker.java that the offset feature is handled early in the Place Marker processing, with stack alignment occurring afterwards. It seems possible that the later is over-riding the offset action.
@riverwanderer riverwanderer added the bug Something isn't working label Nov 28, 2024
riverwanderer added a commit to riverwanderer/vassal that referenced this issue Nov 29, 2024
@riverwanderer
Possible fix for vassalengine#13719. This change explicitly bypasses …
6da977c 
…Place Marker's stack operations when an offset is specified.
@riverwanderer riverwanderer linked a pull request Nov 29, 2024 that will close this issue
Bypass Place Marker stack ops in favour of offset placement #13720
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bypass Place Marker stack ops in favour of offset placement riverwanderer/vassal
1 participant
@riverwanderer