Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player joining message is not sent to other players #12749

Closed
riverwanderer opened this issue Sep 27, 2023 · 0 comments · Fixed by #12768
Closed

Player joining message is not sent to other players #12749

riverwanderer opened this issue Sep 27, 2023 · 0 comments · Fixed by #12768
Assignees
@riverwanderer
Labels
bug Something isn't working
Milestone
3.7.7

Comments

@riverwanderer
Copy link
Collaborator

The message in red, which gives the actual side the player joins with, is not sent to other players, though the format of the message indicates the intention to do so...

image

This is due to a missing getServer().sendToOthers(c) in PlayerRoster finish() method.
@riverwanderer riverwanderer self-assigned this Sep 27, 2023
@riverwanderer riverwanderer added the bug Something isn't working label Sep 27, 2023
@riverwanderer riverwanderer added this to the 3.7.2 milestone Sep 27, 2023
This was linked to pull requests Sep 27, 2023
Fix to joined message not sent to other players #12750
Closed
"Player joins as side" message now broadcast to all players #12768
Merged
@uckelman uckelman modified the milestones: 3.7.2, 3.7.3 Oct 8, 2023
@uckelman uckelman modified the milestones: 3.7.3, 3.7.4, 3.7.5 Oct 16, 2023
@uckelman uckelman modified the milestones: 3.7.5, 3.7.6 Oct 30, 2023
@uckelman uckelman modified the milestones: 3.7.6, 3.7.7 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riverwanderer riverwanderer

Labels
bug Something isn't working
Projects
None yet
Milestone
3.7.7
2 participants
@uckelman @riverwanderer