Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Properties referenced in Set Global Property traits no longer appear as oldName values in 3.7 #12729

Closed
BrentEaston opened this issue Sep 20, 2023 · 0 comments · Fixed by #12730
Closed

Global Properties referenced in Set Global Property traits no longer appear as oldName values in 3.7 #12729

BrentEaston opened this issue Sep 20, 2023 · 0 comments · Fixed by #12730
Assignees
@BrentEaston
Labels
bug Something isn't working
Milestone
3.7.2

Comments

@BrentEaston
Copy link
Collaborator

See discussion at https://forum.vassalengine.org/t/3-7-bug-oldproperty-not-always-reporting/77892

Revert 'bug fix' to allow Set Global Property trait to again report the Global Property via getPropertyNames() so that it appears as an oldName value for reportState.
@BrentEaston BrentEaston self-assigned this Sep 20, 2023
@BrentEaston BrentEaston added the bug Something isn't working label Sep 20, 2023
@BrentEaston BrentEaston added this to the 3.7.2 milestone Sep 20, 2023
@BrentEaston BrentEaston linked a pull request Sep 20, 2023 that will close this issue
12729 Set Global Property to again record old GP value in oldValues for reporting #12730
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrentEaston BrentEaston

Labels
bug Something isn't working
Projects
None yet
Milestone
3.7.2
Development

Successfully merging a pull request may close this issue.

12729 Set Global Property to again record old GP value in oldValues for reporting BrentEaston/vassal
1 participant
@BrentEaston