Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python3.11 and --with-python= #3982

Closed
wants to merge 2 commits into from
Closed

Conversation

catap
Copy link
Contributor

@catap catap commented Sep 15, 2023

No description provided.

@dridi
Copy link
Member

dridi commented Sep 18, 2023

I will look at the other changes, but please remove the --with-python option.

You can already provide a specific python command at configure time:

./configure PYTHON=python3.11

Since we require python, let's not bring back the --with integration (it implies --without too).

@catap
Copy link
Contributor Author

catap commented Sep 18, 2023

@dridi ah; if custom / expected Python can be provided… shall I revert value to default aclocal settings which should be updated one day?

@dridi
Copy link
Member

dridi commented Sep 18, 2023

I don't know, I need to sit down and look at it, but thank you for bringing it up.

@catap
Copy link
Contributor Author

catap commented Sep 18, 2023

See some context here: https://bugs.gnu.org/53530

@dridi
Copy link
Member

dridi commented Sep 18, 2023

If only _AS_PATH_WALK was not an internal macro...

@nigoroll nigoroll assigned nigoroll and dridi and unassigned nigoroll Sep 18, 2023
@catap
Copy link
Contributor Author

catap commented Sep 18, 2023

Well, ./configure ... PYTHON=/bla/bla/python3.11 works as expected.

dridi added a commit that referenced this pull request Sep 26, 2023
If the desired python command is newer than the ones known by aclocal,
we can use the PYTHON variable to select it:

    ./configure PYTHON=python3.11

This already worked before this change, but now we stop chasing python
releases to get them automatically tested.

Refs #3982
@dridi
Copy link
Member

dridi commented Sep 26, 2023

FYI: #3990

@catap
Copy link
Contributor Author

catap commented Sep 26, 2023

Let’s close it when

@catap catap closed this Sep 26, 2023
@catap catap deleted the python3.11 branch September 26, 2023 13:18
dridi added a commit to dridi/varnish-cache that referenced this pull request Sep 26, 2023
If the desired python command is newer than the ones known by aclocal,
we can use the PYTHON variable to select it:

    ./configure PYTHON=python3.11

This already worked before this change, but now we stop chasing python
releases to get them automatically tested.

Refs varnishcache#3982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants