Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Code Quality Improvements #111

Open
6 of 8 tasks
Swayam-code opened this issue Jan 7, 2025 · 8 comments · May be fixed by #115
Open
6 of 8 tasks

Feat: Code Quality Improvements #111

Swayam-code opened this issue Jan 7, 2025 · 8 comments · May be fixed by #115
Assignees
@Swayam-code
Labels
enhancement New feature or request INTERMEDIATE Intermediate level SWOC Associated with SWOC

Comments

@Swayam-code
Copy link

Swayam-code commented Jan 7, 2025 •
edited
Loading

Describe the feature

  • Add proper error boundaries for error handling
  • Add loading states for individual features rather than one global loading state
  • Add proper TypeScript types for better type safety
  • Add input validation for the configuration object
  • Add unit tests for the components and utility functions

Add ScreenShots

image

Record

  • I agree to follow this project's Code of Conduct
  • I'm GSSOC'24 Extd registered Contributor
  • I want to work on this issue
@Swayam-code Swayam-code added the enhancement New feature or request label Jan 7, 2025
@Swayam-code
Copy link
Author

assign me this under "SWOC" label

@vansh-codes
Copy link
Owner

do all the points you mentioned

@vansh-codes vansh-codes added INTERMEDIATE Intermediate level SWOC Associated with SWOC labels Jan 8, 2025
@Abhash-Chakraborty
Copy link
Contributor

Hey @Swayam-code ,

Have started working on the issues assigned?

@Swayam-code
Copy link
Author

Yes, I'm working on it. Will be done by today👍

@Abhash-Chakraborty
Copy link
Contributor

@Swayam-code

I have done some logic changes in the code.
I changed badge rendering to SVG added some files.

Let that merge first :)

@Swayam-code
Copy link
Author

You can create different issue then add your PR to that ,as I'm working on it.

@Swayam-code
Copy link
Author

Swayam-code commented Jan 8, 2025 •
edited
Loading

#115 Fixed this issue.
Except

  • Add proper TypeScript types for better type safety

this requires revamping of the project, so I left it

@Abhash-Chakraborty
Copy link
Contributor

Add tag like
closes: issue_number or Fixes: issue_number
in your PR

Screenshot 2025-01-09 000559

@Swayam-code Swayam-code linked a pull request Jan 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Swayam-code Swayam-code

Labels
enhancement New feature or request INTERMEDIATE Intermediate level SWOC Associated with SWOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ErrorBoundary component with tests and LoadingSpinner Swayam-code/Gityzer
3 participants
@Abhash-Chakraborty @vansh-codes @Swayam-code