Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native only modules are skipped #201

Open
mustafaozhan opened this issue Oct 31, 2022 · 3 comments
Open

Native only modules are skipped #201

mustafaozhan opened this issue Oct 31, 2022 · 3 comments

Comments

@mustafaozhan
Copy link

Hello i just start using the generator and relised that the modules that used in native declarations are ignored.

I am getting below picture
Screenshot 2022-10-31 at 20 52 47

Where my dependency graph should be like in the README.md of the repo.

Please pay attention to provider module which has only native declarations and implements client and res

@vanniktech
Copy link
Owner

I deliberately exclude iOS aae2b91, since I have a lot of export(project(":module")) which will clutter the entire graph

@mustafaozhan
Copy link
Author

Hello sorry for delayed response, I see your point, but maybe we should do it with a flag rather? or with DependencyGraphGeneratorPlugin ?

Currently it works perfect for JVM or Android modules correctly but for Native only modules it looks just not correct, assuming that we can have multiple native only modules, the overall graph will look misleading

@mustafaozhan
Copy link
Author

project-dependency-graph
For example here, all the modules starting with :client... and :ios... is actually used in :ios:provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants