Hi, I'm not sure we want to add this default for 2 reasons.
It seems arbitrary, and not really the responsibility of this plugin.
Also, I feel like this value should be a power of 2 (I remembered testing it and failing with some values).

And finally, there already is a way to do that today, through the same mechanism in the configuration block:

graphviz = { it.totalMemory( /*...*/ ) }

The Graphviz instance configuration has been added here: #183

This should cover the need of #174

@SimonMarquis like #173 (comment) what do you think if we provide a reasonable default for totalMemory like 2^25? That should be enough, right?

Yes we could provide such default, although I think bumping it to 2^25 would not change it that much. (2^24 is the current default)

Didn't know 2^24 is the default, then let's take 2^30?

It comes from here I think: https://github.com/nidi3/graphviz-java/blob/f0c1fdfa37c8b9876ef1dcccec1a6c19219e727e/graphviz-java/src/main/resources/guru/nidi/graphviz/engine/render.js#L2

2.0.pow(30) 👍
We should also do the same for: src/main/kotlin/com/vanniktech/dependency/graph/generator/ProjectDependencyGraphGeneratorTask.kt

Yes it should be consistent. Let's go for 2^30

@tjerkw do you need help to merge this?

I think we can add an extension like this in extensions.kt:

internal fun Graphviz.withDefaultTotalMemory() = totalMemory(2.0.pow(30).toInt())

And use it in both DependencyGraphGeneratorTask and ProjectDependencyGraphGeneratorTask like that:

val graphviz = Graphviz.fromGraph(graph).withDefaultTotalMemory().run(generator.graphviz)

@SimonMarquis Thanks! Updated it.

I missed the discussion but thanks for the help. MR is updated. Feel free to merge.

Sorry will fix

That's what I feared unfortunately.

* What went wrong:
Execution failed for task ':generateDependencyGraph'.
> java.lang.OutOfMemoryError: Direct buffer memory

This setting is not only a limit, but forces to somewhat allocate part of the memory, which triggers this OOM.

We could increase our Xmx config of the tests, but I'm not even sure GitHub Actions will allow this.

But keep in mind users would have to do the same, which is not very obvious from the error message.

Is there any updates? Are you going to merge it?

As explained in my previous comment, this is not a "one size fits all" solution. Therefore and don't think we should merge this. Also, you can manually set it from your own configuration, right?