Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow increase in memory to accommodate larger modules #174

Open
Grimoren opened this issue Jun 15, 2022 · 7 comments · May be fixed by #190
Open

Allow increase in memory to accommodate larger modules #174

Grimoren opened this issue Jun 15, 2022 · 7 comments · May be fixed by #190

Comments

@Grimoren
Copy link

It seems there is an upper limit to how many objects can be graphed:

Encountered this issue on a rather larger application with deeply nested dependencies.
Cannot enlarge memory arrays. Either
// (1) compile with -s TOTAL_MEMORY=X with X higher than the current value 16777216,
// (2) compile with -s ALLOW_MEMORY_GROWTH=1 which allows increasing the size at runtime but prevents some optimizations,
// (3) set Module.TOTAL_MEMORY to a higher value before the program runs, or
// (4) if you want malloc to return NULL (0) instead of this abort, compile with -s ABORTING_MALLOC=0

@tjerkw tjerkw linked a pull request Aug 9, 2022 that will close this issue
@tjerkw
Copy link

tjerkw commented Aug 9, 2022

I created a naive fix by setting a high upper bound.

See nidi3/graphviz-java#12 for more info.

@tjerkw
Copy link

tjerkw commented Aug 9, 2022

@vanniktech can we merge this? This library is not usefull without this fix for us, it fails on our project.

@tjerkw
Copy link

tjerkw commented Aug 28, 2022

Just for reference: This MR allow you to set an upper limit too:

#183

So I think this can be closed @vanniktech

@Grimoren
Copy link
Author

Sure we can close it. Just need an example how to do set this.

@tjerkw
Copy link

tjerkw commented Sep 9, 2022

Yeah, i was trying it but cant use release "latest" and its not in release "0.8.0" yet.

Cann we add it to the docs and create a new release?

@mezpahlan
Copy link

This would be very useful for our project too. Some info in the README and a new release would be much appreciated. Many thanks.

@kenyee
Copy link

kenyee commented Jan 19, 2023

Using the 0.9.0-SNAPSHOT still has the same memory error FYI.
Defaulting it to more memory is probably a good idea...this is on a project with only 200ish modules FYI. I've seen projects with 1000+ modules so this is smallish nowadays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants