Feat time picker display utc #6322
Conversation
|
hey @juicyarts ! |
|
Hey @daniloff200 , this one is related to #5635 , there's another one in my fork that handles offset / #4731 here: https://github.com/juicyarts/ngx-bootstrap/pull/1. It made more sense to align the interface with the datepicker for the offsetTarget and use |
|
@daniloff200 i have a hard time running the whole unit test suite.. see the logs in the observations below. Some observations/issues i documented while working on the prtest runner inconsistenciesWhen running When running in ci pipeline: PASS timepicker src/timepicker/testing/timepicker.component.spec.ts (11.499 s)
PASS timepicker src/timepicker/testing/timepicker-controls.util.spec.ts
FAIL timepicker src/timepicker/testing/timepicker.utils.spec.tssomehow locally the filter is missing the EDIT: my bad, seems like the timepicker.utils.spec are all disabled using Datepicker test suites have issues that cause the runner to be stuckThis behaviour can be reproduces in the PASS datepicker src/datepicker/testing/bs-datepicker-navigation-view.spec.ts
(node:59007) UnhandledPromiseRejectionWarning: TypeError: Converting circular structure to JSON
--> starting at object with constructor 'Zone'
| property '_zoneDelegate' -> object with constructor 'ZoneDelegate'
--- property 'zone' closes the circle
at stringify (<anonymous>)
at writeChannelMessage (internal/child_process/serialization.js:117:20)
at process.target._send (internal/child_process.js:805:17)
at process.target.send (internal/child_process.js:703:19)
at reportSuccess (/Users/yildiz/repos/huess/lib/ngx-bootstrap-ja/node_modules/jest-worker/build/workers/processChild.js:67:11)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:59007) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:59007) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:59009) UnhandledPromiseRejectionWarning: TypeError: Converting circular structure to JSON
--> starting at object with constructor 'Zone'
| property '_zoneDelegate' -> object with constructor 'ZoneDelegate'
--- property 'zone' closes the circle
at stringify (<anonymous>)
at writeChannelMessage (internal/child_process/serialization.js:117:20)
at process.target._send (internal/child_process.js:805:17)
at process.target.send (internal/child_process.js:703:19)
at reportSuccess (/Users/yildiz/repos/huess/lib/ngx-bootstrap-ja/node_modules/jest-worker/build/workers/processChild.js:67:11)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:59009) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:59009) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
● Cannot log after tests are done. Did you forget to wait for something async in your test?
Attempted to log "Unhandled Promise rejection: Failed to load timepicker.component.html ; Zone: ProxyZone ; Task: Promise.then ; Value: Failed to load timepicker.component.html undefined".
at console.error (../../node_modules/@jest/console/build/BufferedConsole.js:161:10)
at Object.api.onUnhandledError (../../node_modules/zone.js/bundles/zone-testing-bundle.umd.js:1104:29)
at handleUnhandledRejection (../../node_modules/zone.js/bundles/zone-testing-bundle.umd.js:1132:17)
at _loop_2 (../../node_modules/zone.js/bundles/zone-testing-bundle.umd.js:1123:21)
at Object.api.microtaskDrainDone (../../node_modules/zone.js/bundles/zone-testing-bundle.umd.js:1127:17)
at drainMicroTaskQueue (../../node_modules/zone.js/bundles/zone-testing-bundle.umd.js:629:22)
at ZoneTask.Object.<anonymous>.ZoneTask.invokeTask [as invoke] (../../node_modules/zone.js/bundles/zone-testing-bundle.umd.js:522:25)
at invokeTask (../../node_modules/zone.js/bundles/zone-testing-bundle.umd.js:1658:18)
at XMLHttpRequest.globalZoneAwareCallback (../../node_modules/zone.js/bundles/zone-testing-bundle.umd.js:1684:21)
at XMLHttpRequest.callTheUserObjectsOperation (../../node_modules/jsdom/lib/jsdom/living/generated/EventListener.js:26:30) |
|
This one https://github.com/juicyarts/ngx-bootstrap/pull/1 builds and tests without any issues.. Since its base is this branch i guess the e2e tests in the last run of this branch were just flaky.. |
Codecov Report
@@ Coverage Diff @@
## development #6322 +/- ##
===============================================
+ Coverage 75.84% 77.07% +1.22%
===============================================
Files 315 312 -3
Lines 10642 10868 +226
Branches 2935 2612 -323
===============================================
+ Hits 8071 8376 +305
+ Misses 2570 2475 -95
- Partials 1 17 +16
Continue to review full report at Codecov.
|
|
So is there something missing or do you want me to change something? Do i need to assign someone here? How can we ensure this PR does not end up like the last one..? :) @daniloff200 |
|
Well, looks good to me, @juicyarts |
|
@juicyarts hello, thank you so much for your work and help |
|
Hey @valorkin, i changed it but am not too sure if this was what you requested. Have a look and let me know if somethings missing. https://github.com/juicyarts/ngx-bootstrap/pull/1 is waiting for this one to be merged, i would adopt the approach of only exposing these options in the config too if thats how you want it. |
|
Hey guys. Don't want to be annoying.. Is there something i can still do here to ? @valorkin & @daniloff200 ? |
|
Holly molly!
|
|
@daniloff200 we're back to our opensource roots) |
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.
closes #5635