Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add message param for ping #149

Closed
wants to merge 2 commits into from
Closed

add message param for ping #149

wants to merge 2 commits into from

Conversation

spyinx
Copy link
Contributor

@spyinx spyinx commented Dec 11, 2024

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

add message param for ping(), so it can be used like real ping command
fix: #146

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.68%. Comparing base (1f6b63c) to head (9a8495b).

❗ There is a different number of reports uploaded between BASE (1f6b63c) and HEAD (9a8495b). Click for more details.

HEAD has 175 uploads less than BASE
Flag BASE (1f6b63c) HEAD (9a8495b)
211 36
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #149       +/-   ##
===========================================
- Coverage   76.21%   62.68%   -13.53%     
===========================================
  Files         130      130               
  Lines       33911    33922       +11     
===========================================
- Hits        25844    21263     -4581     
- Misses       8067    12659     +4592

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spyinx spyinx force-pushed the add-param-for-ping branch from b838613 to 4f02122 Compare December 11, 2024 15:20
@spyinx spyinx closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiven-sal aiven-sal Awaiting requested review from aiven-sal aiven-sal is a code owner

@mkmkme mkmkme Awaiting requested review from mkmkme mkmkme is a code owner

@ahmedsobeh ahmedsobeh Awaiting requested review from ahmedsobeh ahmedsobeh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize ping() method
2 participants
@spyinx @codecov-commenter