Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Configure AWS SDK clients directly, rather than setting environment variables #530

Open
TylerGillson opened this issue Nov 27, 2024 · 0 comments
Labels
enhancement Enhancement to an existing feature

Comments

@TylerGillson
Copy link
Member

Summary

We should not be using env vars to implicitly configure AWS SDK clients. We should configure them explicitly using the SDK constructor. Env vars can be defaults (provided by the Helm charts) that get overridden with explicit auth per AWSValidator. This is more idiomatic and prevents contention between multiple AWSValidators reconciled concurrently with differing auth configuration. Currently that is not an issue because we don't support configuring MaxConcurrentReconciles, but is a good improvement nevertheless.

@TylerGillson TylerGillson added the enhancement Enhancement to an existing feature label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant