Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocklight/Skylight support #672

Open
maxomatic458 opened this issue Oct 28, 2024 · 2 comments
Open

Blocklight/Skylight support #672

maxomatic458 opened this issue Oct 28, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@maxomatic458
Copy link
Contributor

valence does not support lighting when loading minecraft worlds yet.

im probably gonna try implementing that myself, but i wanted to open a issue first, so feel free to share any thoughts here.

hyperion can be used as reference as that seems to implement that already: https://github.com/andrewgazelka/hyperion/blob/f801eddab96f10fc8179f7e1862d5206ec61425a/crates/hyperion/src/simulation/blocks/loader/parse.rs#L259-L288
@maxomatic458 maxomatic458 added the enhancement New feature or request label Oct 28, 2024
@Cheezer1656
Copy link
Contributor

It would be cool if you could make it toggleable for every player using a component or something. Then we could have server-side fullbright that can be adjusted individually.

@andrewgazelka
Copy link

feel free to let me know if you have any questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andrewgazelka @maxomatic458 @Cheezer1656 and others