Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component to control entity view distance. #441

Open
rj00a opened this issue Aug 4, 2023 · 0 comments
Open

Add component to control entity view distance. #441

rj00a opened this issue Aug 4, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@rj00a
Copy link
Member

rj00a commented Aug 4, 2023

Describe the problem related to your feature request.

The view distance of entities and the view distance of chunks are one and the same in Valence. However, the client will stop rendering entities past a certain distance, so it's a waste to keep sending packets for those entities.

What solution would you like?

Split the existing ViewDistance component in two: ChunkViewDistance and EntityViewDistance. ChunkViewDistance is still in control of the view distance "fog" effect and is the "real" view distance understood by the protocol.

Internally, the real value of EntityViewDistance is clamped such that entity_view_distance <= chunk_view_distance since entities don't render past the chunk view distance.

What alternative(s) have you considered?

To reduce complexity, we could have the entity view distance fixed to whatever that maximum render distance for entities is.

@rj00a rj00a added the enhancement New feature or request label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant