Update key package functionality #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemenkina
force-pushed
the
fix_key_package
branch
from
ec1c0f2 to
e0cc284
Compare
seemenkina
force-pushed
the
fix_key_package
branch
from
e0cc284 to
379aca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this PR I corrected adding user data to the chain
I also commented out the local cache here, as it is not actually used now (the one embedded in openmls is used).
After these changes it will be possible to move the functions -
getAllKeyPackagesForUser,getUserto a separate branch, but already in another PR