fix: close popover with hover trigger on target mousedown #8216
Conversation
|
| @@ -550,6 +551,7 @@ class Popover extends PopoverPositionMixin( | |||
| target.addEventListener('click', this.__onTargetClick); | |||
| target.addEventListener('mouseenter', this.__onTargetMouseEnter); | |||
| target.addEventListener('mouseleave', this.__onTargetMouseLeave); | |||
| target.addEventListener('mousedown', this.__onTargetMouseDown); | |||
There was a problem hiding this comment.
This doesn't solve the issue if the dialog is opened with keyboard.
There was a problem hiding this comment.
Right, I didn't consider this case. Maybe we should close it on click from keyboard even if the popover doesn't have click trigger.
There was a problem hiding this comment.
There's one problem when setting popover.trigger = ['hover', 'focus'];:
popover-wtf.mp4
This makes sense since mousedown is not prevented and triggers focusin event and the popover re-opens on focus. Note: in vaadin-tooltip we don't have this problem since unlike the popover, tooltip only opens on keyboard focus.
Maybe there should be some way to notify previous overlays in the stack when a new one is opened so they could decide whether they should close or not (e.g. in case of vaadin-popover it might make sense to close it when it was opened on hover and the new overlay is not a "nested" one).
I'll close the PR for now and will continue investigating.
Description
Fixes #8197
Added logic to close the popover on
mousedownto align with the tooltip behavior.Note: when using
hoverandclicktriggers this isn't used since in this case the click event would immediately reopen the popover previously closed onmousedown. However, I think this combination shouldn't be widely used.Type of change