Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand last calculation doesn't take header into account #9

Open
juuso-vaadin opened this issue Nov 29, 2022 · 0 comments
Open

Expand last calculation doesn't take header into account #9

juuso-vaadin opened this issue Nov 29, 2022 · 0 comments

Comments

@juuso-vaadin
Copy link
Contributor

The value calculated for --_expand-last-height doesn't seem to take part="header" into account.

Using the header slot will result the value being too big and scrollbar to appear when it's not needed.

Steps to reproduce

  1. Open component demo https://incubator.app.fi/anchor-nav-demo/anchor-nav
  2. Set height of vcf-anchor-nav to 600px
  3. Height of header is 130px and height of tabs is 44px
  4. The value for --_expand-last-height should be 600px - 130px - 44px = 426px
  5. The value for --_expand-last-height is 556px
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@juuso-vaadin