Update cucumber testsuite module to match new naming #1662
Conversation
maximenoel8
force-pushed
the
rename_cucumber_testsuite_module
branch
from
04b5dcf
to
3ff930b
Compare
maximenoel8
force-pushed
the
rename_cucumber_testsuite_module
branch
from
fc72384
to
8b49a41
Compare
maximenoel8
force-pushed
the
rename_cucumber_testsuite_module
branch
2 times, most recently
from
62edc85
to
2f0a300
Compare
| } | ||
| redhat-minion = { | ||
| redlike_minion = { |
There was a problem hiding this comment.
| redlike_minion = { | |
| rhlike_minion = { |
| @@ -42,7 +42,7 @@ locals { | |||
| names = { for host_key in local.hosts : | |||
| host_key => lookup(var.host_settings[host_key], "name", null) if var.host_settings[host_key] != null ? contains(keys(var.host_settings[host_key]), "name") : false } | |||
| install_salt_bundle = { for host_key in local.hosts : | |||
| host_key => lookup(var.host_settings[host_key], "install_salt_bundle", false) if var.host_settings[host_key] != null } | |||
| host_key => lookup(var.host_settings[host_key], "install_salt_bundle", true) if var.host_settings[host_key] != null } | |||
There was a problem hiding this comment.
Fine with this, not sure if that should be in another PR.
Anyway, let's at least comment it on the description of the PR please.
| client_configuration = contains(local.hosts, "suse_client") ? module.suse_client.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] } | ||
| minion_configuration = contains(local.hosts, "suse_minion") ? module.suse_minion.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] } | ||
| sshminion_configuration = contains(local.hosts, "suse_sshminion") ? module.suse_sshminion.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] } | ||
| slemicro_minion_configuration = contains(local.hosts, "slemicro_minion") ? module.slemicro_minion.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] } |
There was a problem hiding this comment.
I wonder if for those we want also to rename the configuration variable name, to have something like... suse_minion_configuration for example.
There was a problem hiding this comment.
Definitely. I added a todo for that. I was looking at the redhat, debian conf but those confs too. I will need those changes in a separate PR because it also require some changes on controller salt states.
I'm not sure what need to be changes. Don't hesitate to create an issue and assign it to me we the changes you see. BV will not be impacted by this change because we don't use this module. |
https://github.com/SUSE/spacewalk/pull/25809 should take care of this |
maximenoel8
force-pushed
the
rename_cucumber_testsuite_module
branch
from
2f0a300
to
eeb821d
Compare
What does this PR change?
Update cucumber testsuite module to match new naming.
New hostname naming:
Module names are the same using an
_instead of-Also change the default value for
install_salt_bundlefrom false to true (align with module default value). It will remove the need of adding https://github.com/SUSE/susemanager-ci/blob/8ed2e0bcba38461cf5d0e445d75264a3d1a31a51/terracumber_config/tf_files/SUSEManager-4.3-NUE.tf#L204 for all pipelines using cucumber_testsuite module.Related to: https://github.com/SUSE/spacewalk/issues/25062
Discussion: https://suse.slack.com/archives/C02D134507M/p1731289062684489