Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken HTML when user not logged in #162

Open
solarissmoke opened this issue Mar 5, 2013 · 0 comments
Open

Broken HTML when user not logged in #162

solarissmoke opened this issue Mar 5, 2013 · 0 comments

Comments

@solarissmoke
Copy link

Hi,

I spotted a couple of issues on uchaguzi.co.ke:

  1. The doctype is for XHTML 1.0 Transitional, but the code uses HTML5 elements (header/footer etc) which causes issues in some browsers. I think changing it to the HTML5 doctype will fix that.
  2. There's something not quite right in https://github.com/ushahidi/uchaguzi/blob/master/application/views/header_nav.php . The .userinfo div is opened at the top, but is only closed inside the if($loggedin_user != FALSE) block. Similarly, the .userdata and .userinfodrop divs are only opened if a user is logged in, but are closed regardless. This results in unbalanced opening/closing tags for anonymous users which breaks HTML further down the page.

I would submit a pull request but I'm not sure what the intended structure of these divs is for logged-in/anonymous users!

Cheers,

Samir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant