From 6863e517661b2e502088c116ff64de3572f597bc Mon Sep 17 00:00:00 2001
From: bohmaniac <vincent.isegranbohman@gmail.com>
Date: Tue, 29 Oct 2024 12:34:56 +0100
Subject: [PATCH 1/2] Added back mobile phone responsiveness

Updated base.html.twig to be mobile phone responsive again.
---
 app/templates/pages/abstract/base.html.twig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/templates/pages/abstract/base.html.twig b/app/templates/pages/abstract/base.html.twig
index 771c2086..757a028a 100644
--- a/app/templates/pages/abstract/base.html.twig
+++ b/app/templates/pages/abstract/base.html.twig
@@ -7,6 +7,7 @@
             <meta http-equiv='Content-Type' content='text/html; charset=utf-8'>
             <meta name="generator" content="UserFrosting" />
             <meta name="description" content="{{ block('page_description')|e }}">
+            <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no">
             <meta name="author" content="{% block page_author %}{{ site.author }}{% endblock %}">
 
             <title>{{ site.title }} | {% block page_title %}{% endblock %}</title>

From ec79ef9928c19f1ba26bbb670b4396ba655e5090 Mon Sep 17 00:00:00 2001
From: Louis Charette <charette.louis@gmail.com>
Date: Fri, 29 Nov 2024 19:37:17 -0500
Subject: [PATCH 2/2] Add PHP 8.4 to tests

---
 .github/workflows/Build.yml                         | 12 ++++++------
 .github/workflows/PHPStan.yml                       |  2 +-
 app/src/Database/Relations/BelongsToManyThrough.php |  6 +++---
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/Build.yml b/.github/workflows/Build.yml
index 1b6722c9..090e3d4f 100644
--- a/.github/workflows/Build.yml
+++ b/.github/workflows/Build.yml
@@ -15,7 +15,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php_versions: ['8.1', '8.2', '8.3']
+        php_versions: ['8.1', '8.2', '8.3', '8.4']
 
     runs-on: ubuntu-latest
     name: PHPUnit - PHP ${{ matrix.php_versions }} - Memory SQLite
@@ -64,7 +64,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php_versions: ['8.1', '8.2', '8.3']
+        php_versions: ['8.1', '8.2', '8.3', '8.4']
 
     runs-on: ubuntu-latest
     name: PHPUnit - PHP ${{ matrix.php_versions }} - MySQL
@@ -137,7 +137,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php_versions: ['8.1', '8.2', '8.3']
+        php_versions: ['8.1', '8.2', '8.3', '8.4']
 
     runs-on: ubuntu-latest
     name: PHPUnit - PHP ${{ matrix.php_versions }} - MariaDB
@@ -203,7 +203,7 @@ jobs:
       strategy:
         fail-fast: false
         matrix:
-          php_versions: ['8.1', '8.2', '8.3']
+          php_versions: ['8.1', '8.2', '8.3', '8.4']
 
       runs-on: ubuntu-latest
       name: PHPUnit - PHP ${{ matrix.php_versions }} - SQLite
@@ -259,7 +259,7 @@ jobs:
       strategy:
         fail-fast: false
         matrix:
-          php_versions: ['8.1', '8.2', '8.3']
+          php_versions: ['8.1', '8.2', '8.3', '8.4']
 
       runs-on: ubuntu-latest
       name: PHPUnit - PHP ${{ matrix.php_versions }} - PostgreSQL
@@ -321,7 +321,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-          php_versions: ['8.1', '8.2', '8.3']
+          php_versions: ['8.1', '8.2', '8.3', '8.4']
 
     runs-on: windows-latest
     name: PHPUnit - PHP ${{ matrix.php_versions }} - Windows
diff --git a/.github/workflows/PHPStan.yml b/.github/workflows/PHPStan.yml
index f7e8cc18..9d5aeabf 100644
--- a/.github/workflows/PHPStan.yml
+++ b/.github/workflows/PHPStan.yml
@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php_versions: ['8.1', '8.2', '8.3']
+        php_versions: ['8.1', '8.2', '8.3', '8.4']
 
     runs-on: ubuntu-latest
     name: PHPStan - ${{ matrix.php_versions }}
diff --git a/app/src/Database/Relations/BelongsToManyThrough.php b/app/src/Database/Relations/BelongsToManyThrough.php
index 8d14ae2f..d32d4437 100644
--- a/app/src/Database/Relations/BelongsToManyThrough.php
+++ b/app/src/Database/Relations/BelongsToManyThrough.php
@@ -94,12 +94,12 @@ public function getExistenceCompareKey(): string
     /**
      * Add a "via" query to load the intermediate models through which the child models are related.
      *
-     * @param string|null $viaRelationName
-     * @param callable    $viaCallback
+     * @param string|null   $viaRelationName
+     * @param callable|null $viaCallback
      *
      * @return self
      */
-    public function withVia(?string $viaRelationName = null, callable $viaCallback = null): self
+    public function withVia(?string $viaRelationName = null, ?callable $viaCallback = null): self
     {
         $this->tertiaryRelated = $this->intermediateRelation->getRelated();