chore: upgrade useink and setup vite #288
Conversation
✅ Deploy Preview for inklink ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This complete @statictype @DoubleOTheven, clippy and contract test have been failing since Aug 19, 2022 https://github.com/paritytech/link/commits/master. Should we remove them? |
| @@ -20,7 +20,8 @@ export const useSubmitHandler = () => { | |||
| setSubmitting(false); | |||
| } | |||
|
|
|||
| if (!result?.status.isInBlock) return; | |||
There was a problem hiding this comment.
@gaboesquivel we shouldn't comment out broken functionality.
@DoubleOTheven please look into why ContractSubmittableResult seems to incorrectly extend SubmittableResult in useInk.
Here is the expected shape.
If you undo the comments in this file, you will get build errors:
error TS2339: Property 'events' does not exist on type 'ContractSubmittableResult'.
error TS2339: Property 'dispatchError' does not exist on type 'ContractSubmittableResult'.
There was a problem hiding this comment.
good catch, I didn't realized that was missing
| import { useLinkContract } from './hooks'; | ||
| import { AbiMessage, ContractExecResult, Registry } from 'useink/core'; | ||
| import { useAbiMessage } from 'useink'; | ||
| import { hexToString } from './lib/converter'; |
There was a problem hiding this comment.
can you explain why you changed the hexToString import?
There was a problem hiding this comment.
it seems the new version of useink doesnt export that function
| "useDefineForClassFields": true, | ||
| "lib": ["ES2020", "DOM", "DOM.Iterable"], | ||
| "module": "ESNext", | ||
| "skipLibCheck": true, |
There was a problem hiding this comment.
please change skipLibCheck back to false
There was a problem hiding this comment.
@DoubleOTheven when I disable skipLibCheck compiler is not able to find many dependencies of useink.
Perhaps they should be defined as dependencies or specified as peer dependencies?
Sometimes those tests fail due to CI problems, not actual broken functionality. This is probably the reason, we haven't touched the contract code. That part would really need some love, it's still on ink! v3. wdyt @cmichi? |
No description provided.