Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about the code #8

Open
Wang3sui opened this issue Oct 17, 2024 · 3 comments
Open

about the code #8

Wang3sui opened this issue Oct 17, 2024 · 3 comments

Comments

@Wang3sui
Copy link

Dear authors, I really appreciate your amazing work.May I ask some questions regarding the code? In the SelfAttention_Family.py file, the TriangularCausalMask and ProbMask methods are called, but the masking class is not defined in the utils.py file. Therefore, the methods TriangularCausalMask and ProbMask do not exist. As a result, the statement from utils.masking import TriangularCausalMask, ProbMask and the calls to these two methods cause errors.

@willzhang3
Copy link
Collaborator

I think we didn't actually use the files SelfAttention_Family.py and Transformer_EncDec.py. Therefore, this could likely be addressed by simply commenting out the code that involves them.

@Wang3sui
Copy link
Author

Thank you for your response, but I have another code-related question. In person_activity.py, the second-to-last line ariable_time_collate_fn_activity seems to have a similar issue, as ariable_time_collate_fn_activity does not appear to be defined. How can I resolve this?

@willzhang3
Copy link
Collaborator

We did not use the function "variable_time_collate_fn_activity". Please follow our instructions to reproduce the experiments, and do not directly run the file person_activity.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants