Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail spacing disappears #1

Open
MistressAshai opened this issue Jun 18, 2020 · 2 comments
Open

Thumbnail spacing disappears #1

MistressAshai opened this issue Jun 18, 2020 · 2 comments

Comments

@MistressAshai
Copy link

When in a folder, sometimes the file spacing disappears.
This mainly seems to happen when I scroll through the folder.

github

@usagirei
Copy link
Owner

usagirei commented Jun 18, 2020

Yeah, i've had that happen, but i think its an windows explorer problem:

Microsoft's own guidelines state that if a thumbnail of size 256 is requested, for the handler to provide a non-padded, maximum available sized image with a maximum dimension of 256 in its original aspect ratio (so i'd provide a 256x128 image for a 192x96 .sar), then windows explorer is responsible for padding it.

Additionally, it's also stated to not add adornments like the drop-shadows pictures have around them that windows explorer is also responsible for adding it, but i've yet to see this happen.

I've figured out the drop shadow part at least.

@usagirei
Copy link
Owner

usagirei commented Jun 19, 2020

@MistressAshai try updating with the new release (v1.0.0.31), after i added the thumbnail frame registry entry, i haven't had the icon collapse on itself, even after agressively scrolling through my cache dir

EDIT:

Nvm, when editing the readme to include a new screenshot with the shadows, the icons were small-ish, it may be intentional design, I can trigger it by changing the icon types from tiles to large, medium icons, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants