Upgrade Everything #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
Squashed commit of the following: commit c28c581 Author: Tim <[email protected]> Date: Tue Sep 17 08:16:42 2024 +0200 fix dependency errors Signed-off-by: Tim <[email protected]> commit 3db1b2a Author: Tim <[email protected]> Date: Tue Sep 17 01:03:48 2024 +0200 fix more errors Signed-off-by: Tim <[email protected]> commit e26af6f Author: Tim <[email protected]> Date: Tue Sep 17 00:06:51 2024 +0200 fix codegen Signed-off-by: Tim <[email protected]> commit 2a007e3 Author: Tim <[email protected]> Date: Mon Sep 16 22:43:25 2024 +0200 sunken cost fallacy. upgrade everything! Signed-off-by: Tim <[email protected]> commit e043178 Author: Tim <[email protected]> Date: Mon Sep 16 19:36:47 2024 +0200 try to upgrade upjet to 1.4 Signed-off-by: Tim <[email protected]> Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
remove deprecated configuration from .golangci.yml Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
|
@Avarei thanks for the PR. Much appreciated. We'll take a look. |
|
Hi fellows, Any chance we could get this one merged? Any way we could help out? Tnks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I recently started using this provider and I noticed two things that need to be fixed before I can use it.
To fix the CVEs I upgraded various dependencies:
Since I still encountered the second issue after the first set of upgrades I also upgraded go to 1.23 and upjet to 1.4.1.
And since then I did not have any issues with resource creation.
Also most CVEs from the previous version are gone.
I also added the three new resources that have been added to the provider in the newest version:
However this PR also comes with a few caveats:
I could not getmake lintto pass due to typecheck golangci-lint.logThereforemake reviewablefailsI have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
The provider has been built using make build.all and used in a dev environment for a few days.
It has been deployed to a dev environment and a small selection of resources have been deployed successfully.