From 701757ffa20488e3b9c23e146fdcee0b69a0014b Mon Sep 17 00:00:00 2001 From: Jordan Levin Date: Wed, 8 May 2024 09:00:17 -0700 Subject: [PATCH] address comments Signed-off-by: Jordan Levin --- config/provider.go | 2 +- config/{vault_namespace => vault}/config.go | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) rename config/{vault_namespace => vault}/config.go (74%) diff --git a/config/provider.go b/config/provider.go index 2d97d83c..8f6c7df7 100644 --- a/config/provider.go +++ b/config/provider.go @@ -10,7 +10,7 @@ import ( ujconfig "github.com/upbound/upjet/pkg/config" - vaultnamespace "github.com/upbound/provider-vault/config/vault_namespace" + vaultnamespace "github.com/upbound/provider-vault/config/vault" ) const ( diff --git a/config/vault_namespace/config.go b/config/vault/config.go similarity index 74% rename from config/vault_namespace/config.go rename to config/vault/config.go index bcf5b30b..9a5f1512 100644 --- a/config/vault_namespace/config.go +++ b/config/vault/config.go @@ -1,4 +1,4 @@ -package vault_namespace +package vault import "github.com/upbound/upjet/pkg/config" @@ -7,7 +7,5 @@ func Configure(p *config.Provider) { p.AddResourceConfigurator("vault_namespace", func(r *config.Resource) { r.Kind = "VaultNamespace" r.ShortGroup = "vault" - r.UseAsync = true - r.ExternalName = config.IdentifierFromProvider }) }