Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo): add composition for argo #2

Merged
merged 1 commit into from
Nov 17, 2023
Merged

feat(argo): add composition for argo #2

merged 1 commit into from
Nov 17, 2023

Conversation

haarchri
Copy link
Member

Description of your changes

add composition for argo

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

--- PASS: kuttl (139.55s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (139.05s)
PASS
00:38:25 [ OK ] running automated tests

@haarchri
Copy link
Member Author

/test-examples

ytsarev
ytsarev reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, some inline documentation (simple comments would do) on the specific decisions would be really helpful long term

apis/composition.yaml
apiGroups:
- "*"
resource.customizations: |
"*.upbound.io/*":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we somehow document this lua customization?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in readme or what is your idea ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline.

apis/composition.yaml
prometheus.io/scrape: true
env:
- name: ARGOCD_K8S_CLIENT_QPS
value: "300"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we document this specific value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in readme or what is your idea ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline should be sufficient.

@haarchri haarchri merged commit 402613d into main Nov 17, 2023
@haarchri haarchri deleted the feature/argocd branch November 18, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytsarev ytsarev ytsarev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haarchri @ytsarev