Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Team by drag and drop #36

Open
ApolloLV opened this issue Apr 28, 2020 · 7 comments
Open

Switch Team by drag and drop #36

ApolloLV opened this issue Apr 28, 2020 · 7 comments
Assignees
Labels
Client enhancement New feature or request
Milestone

Comments

@ApolloLV
Copy link
Collaborator

Currently there are 3 buttons with one triggering a dropdown menu for transferring players. If we put everything into a single dropdown, this should clean up the interface a little and get us around issues like labelling requirements.

@stheid
Copy link
Collaborator

stheid commented Apr 29, 2020

I am actually a big fan of the current layout. i would only remove the "switch team" by drag and drop

@ApolloLV
Copy link
Collaborator Author

The advantage of a dropdown menu would be that we don't need to come up with cryptic icons.
I'd also like to see the drag and drop solution, but it should also have a icon communicating the possibility of moving players around

@stheid
Copy link
Collaborator

stheid commented Apr 29, 2020

the icons as they are, perfect as they are right now. just add tooltips and everyone is happy. noone complained about the icons. and also the move player icon is very good. a dropdown is unnececary clicks that make it more difficult expecially on mobile devices.

@moreApi moreApi added bug Something isn't working question Further information is requested labels May 1, 2020
@moreApi moreApi added this to the Version n+1 milestone May 1, 2020
@stheid stheid added Client enhancement New feature or request and removed bug Something isn't working labels May 7, 2020
@stheid stheid removed the question Further information is requested label May 16, 2020
@stheid stheid modified the milestones: Version n+1, Version 2.1 May 16, 2020
@stheid stheid self-assigned this May 16, 2020
@stheid stheid changed the title [clientJS] Single player dropdown menu Switch Team by drag and drop May 16, 2020
@stheid
Copy link
Collaborator

stheid commented May 16, 2020

After discussion (@ApolloLV) we agreed to keep the drop-down as is and add drag and drop funktionality for switcing teams.

this will be implemented with jquery-ui

@stheid
Copy link
Collaborator

stheid commented May 21, 2020

TODO

  • revert if drag was unsuccesfull (if the callback function failed)
    • for now this could be solved with revert:true. this will revert the button, but the next gamestate will show the sucessful update
    • [later] functions are also supported, so we could handle it properly (https://stackoverflow.com/a/28818897/13310191)
    • [later] append buttongroup to drop target in order to visually show succesfull drop before state update)
  • visual feedback at dropable
  • prevent click events when dragging the buttongroup (https://stackoverflow.com/a/2526029/13310191)
  • [later] incorporate sorting.

@stheid stheid modified the milestones: Version 2.1, Version 2.2 May 22, 2020
@stheid
Copy link
Collaborator

stheid commented May 22, 2020

the issue is a little more complicated than i anticipated

stheid pushed a commit that referenced this issue May 22, 2020
stheid pushed a commit that referenced this issue May 26, 2020
@stheid stheid modified the milestones: Version 2.2, Version 2.3 Jun 12, 2020
@moreApi moreApi modified the milestones: Version 2.4, Version 2.5 Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants