Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into limiting incoming requests #33

Open
jechols opened this issue Mar 3, 2020 · 0 comments
Open

Look into limiting incoming requests #33

jechols opened this issue Mar 3, 2020 · 0 comments
Labels
enhancement low-priority unnecessary enhancements that may be nice, but nobody would really mind if we just closed them

Comments

@jechols
Copy link
Member

jechols commented Mar 3, 2020

Go's standard http package is a little too willing to accept requests, so when concurrency reaches absurd levels (say 20+ concurrent requests), all the requests are fighting for very limited resources, which can cause responses to take a very long time.

We could implement a worker queue of some sort in the image processing code, perhaps. Kind of hacky, but it would prevent the server from getting into a death spiral where the slowness causes requests to keep piling up, which makes things even slower, etc.

Then again, this has never caused problems outside of extreme load testing - real-world use just doesn't get that heavy. Definitely not a major priority.

@jechols jechols added enhancement low-priority unnecessary enhancements that may be nice, but nobody would really mind if we just closed them labels Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement low-priority unnecessary enhancements that may be nice, but nobody would really mind if we just closed them
Projects
None yet
Development

No branches or pull requests

1 participant