Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw on file parse errors #47

Open
rtm516 opened this issue Mar 2, 2024 · 0 comments
Open

Don't throw on file parse errors #47

rtm516 opened this issue Mar 2, 2024 · 0 comments
Assignees

Comments

@rtm516
Copy link

rtm516 commented Mar 2, 2024

Currently, if a single invalid file tries to get parsed the whole parsing crashes with an error, it should do some form of warn and continue. This would mean if single files failed to parse then we would still get an output just with some bits missing.

The crash out is due to this throw inside a try-catch

} catch (IOException e) {
throw new UncheckedIOException("Failed to deserialize resource at: '" + path + "'", e);
}

@yusshu yusshu self-assigned this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants