Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata should be independent #27

Open
yusshu opened this issue Oct 8, 2023 · 0 comments
Open

Metadata should be independent #27

yusshu opened this issue Oct 8, 2023 · 0 comments
Assignees
@yusshu
Labels
enhancement New feature or request

Comments

@yusshu
Copy link
Member

yusshu commented Oct 8, 2023

The Metadata type should be independent and represent any .mcmeta file for any key.
This would remove the Metadatable interface and remove Metadata from the Texture class

Why?

Metadata have their own files, so, they are independent, they may function as replacements by overlays or filters for other resource packs.
Currently, independent metadata (metadata that is not attached to an existing file) is completely ignored and discarded by the MinecraftResourcePackReader class.

However, this would make Texture & other classes usage more complex and time-consuming.
@yusshu yusshu self-assigned this Oct 29, 2023
@yusshu yusshu added the enhancement New feature or request label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yusshu yusshu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yusshu