Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): union ibc spec #3201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(docs): union ibc spec #3201

wants to merge 1 commit into from

Conversation

hussein-aitlahcen
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
site ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 10:48am

Copy link

github-actions bot commented Nov 4, 2024

Docs 🤌

✨ Deployment complete! Take a peek over at https://8a75bd2f.docs-ajn.pages.dev
✨ Deployment alias URL: https://head.docs-ajn.pages.dev


Copy link
Contributor

@aeryz aeryz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also changed recvPacket to get multiple packets instead of one.

docs/src/content/docs/protocol/specifications/ibc.mdx Outdated Show resolved Hide resolved

- [`connectionId`](https://github.com/cosmos/ibc/tree/41a8caa54d8691b7fa98795d31f401e1df31e18c/spec/core/ics-003-connection-semantics#identifier-validation) is no longer a string but a unique `uint32`.
- [`ConnectionEnd`](https://github.com/cosmos/ibc/tree/41a8caa54d8691b7fa98795d31f401e1df31e18c/spec/core/ics-003-connection-semantics#data-structures)
- `counterpartyPrefix` has been removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps explain that this is to be done in the light client now?

- [`Packet`](https://github.com/cosmos/ibc/blob/41a8caa54d8691b7fa98795d31f401e1df31e18c/spec/core/ics-004-channel-and-packet-semantics/README.md#definitions)
- `sourcePort` has been removed.
- `destinationPort` has been removed.
- `timeoutHeight` type has been changed from `(uint64, uint64)` to `uint64`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain that revision number is removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants