Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalization not lowercasing sender/receiver #2749

Closed
cor opened this issue Aug 14, 2024 · 3 comments
Closed

Fix normalization not lowercasing sender/receiver #2749

cor opened this issue Aug 14, 2024 · 3 comments
Assignees
Labels
A-hubble Area: Our Hubble chain indexer P-high High priority

Comments

@cor
Copy link
Contributor

cor commented Aug 14, 2024

Some examples:
D990d551792d22996a1E0b5637008F2e9A6C3882

Image
this is blocking #2711

@cor cor added A-hubble Area: Our Hubble chain indexer P-high High priority labels Aug 14, 2024
@cor cor assigned qlp Aug 14, 2024
@KaiserKarel
Copy link
Contributor

I've lowered this in v0.transfers now @qlp, which resolves the immediate issue but won't be super friendly to indexes etc.

@KaiserKarel
Copy link
Contributor

Should adjust this in v0.transfers_view such that we store them lowered.

@qlp
Copy link
Contributor

qlp commented Aug 15, 2024

@KaiserKarel I've fixed all duplicate key issues in push tables and reverted you 'lower' patch.

results are the same:

select * from (
             SELECT transfers_push.sender,
       transfers_push.receiver,
       lower(transfers_push.normalized_sender)   AS normalized_sender_lower,
       transfers_push.normalized_sender,
       lower(transfers_push.normalized_receiver) AS normalized_receiver_lower,
       transfers_push.normalized_receiver,
       transfers_push.source_transaction_hash,
       transfers_push.source_transaction_index,
       transfers_push.source_timestamp
FROM transfers_push) t
         where t.normalized_receiver_lower <> t.normalized_receiver or
               t.normalized_sender_lower <> t.normalized_sender
 order by t.source_timestamp desc
limit 500

results in just 15 rows (all a result of non-delete records after block reorgs). I'll create a new item to fix that

@qlp qlp closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-hubble Area: Our Hubble chain indexer P-high High priority
Projects
None yet
Development

No branches or pull requests

3 participants