AVR support #2021
Open
AVR support #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsec
force-pushed
the
to_upstream/feature/avr
branch
from
3b071ab to
7c958ea
Compare
aquynh
reviewed
Oct 3, 2024
samples/sample_avr.c
Outdated
| break; | ||
|
|
||
| // Initialize registers | ||
| uint8_t regs[32]; |
There was a problem hiding this comment.
please move all the variable declaration to the beginning of the function
|
Thanks for the contribution!
|
|
can you look at the issues of the CI? |
|
You need to add Rust bindings manually😅 |
glennsec
force-pushed
the
to_upstream/feature/avr
branch
from
7c958ea to
ade427c
Compare
done |
Fixed all of those except arm64 & ppc64 failures. The arm64 bits may be fixed by #1935 ? |
There are also macos failures. |
Hi, this is related to the tcg/aarch64 backend issue mentioned in #1908 with proposed fix in #1935. I have another patch suggestion that fixes the issue, as you can see in the last CI run at https://github.com/glennsec/unicorn/actions/runs/11298077207 |
Directly jump into the slow path when there is any hookmem enabled. This fixes unicorn-engine#1908. Signed-off-by: Glenn Baker <[email protected]>
Directly jump into the slow path when there is any hookmem enabled. Signed-off-by: Glenn Baker <[email protected]>
glennsec
force-pushed
the
to_upstream/feature/avr
branch
from
ade427c to
237c20e
Compare
Use has_hookmem() helper to determine wether "slow-path" TLB read is needed. Add this helper to x86 architecture as well so that to check for all hookmem. Signed-off-by: Glenn Baker <[email protected]>
It's the same implementation for all architectures, so factor out has_hookmem() into tcg_uc_has_hookmem(). Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Add AVR related definitions into QEMU, make AVR support buildable. [AM: Remove word 'Atmel' from filenames and all elements of code] Suggested-by: Aleksandar Markovic <[email protected]> Signed-off-by: Michael Rolnik <[email protected]> Signed-off-by: Richard Henderson <[email protected]> Signed-off-by: Aleksandar Markovic <[email protected]> Tested-by: Philippe Mathieu-Daudé <[email protected]> Reviewed-by: Aleksandar Markovic <[email protected]> Signed-off-by: Thomas Huth <[email protected]> Message-Id: <[email protected]> [PMD: Fixed @avr tag in qapi/machine.json] Signed-off-by: Philippe Mathieu-Daudé <[email protected]> (cherry picked from commit 42f3ff001339e37df4f13b709d2db00a488ee45c) Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
This is needed because the AVR CPU has separate code and data address spaces that both start from zero. Use 0x08000000 base for Flash memory and 0x00000000 base for CPU registers, IO registers and SRAM as the fast case. Signed-off-by: Glenn Baker <[email protected]>
Separate AVR architectures ("avr5", "avr51", "avr6", etc.) from actual
MCU models. Only list the most representative MCU models.
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
Signed-off-by: Glenn Baker <[email protected]>
glennsec
force-pushed
the
to_upstream/feature/avr
branch
from
237c20e to
9a25b59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this adds support for AVR (#939), while keeping XMEGA bits (with DES instruction) currently separate. This PR is rebased against the current dev branch, while original support was developed and more thoroughly tested against unicorn 2.0.x.