Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DecimalDigitsV1 numbering systems sets should be configurable #5824

Closed
Manishearth opened this issue Nov 15, 2024 · 2 comments · Fixed by #5962
Closed

DecimalDigitsV1 numbering systems sets should be configurable #5824

Manishearth opened this issue Nov 15, 2024 · 2 comments · Fixed by #5962
Labels
C-data-infra Component: provider, datagen, fallback, adapters discuss Discuss at a future ICU4X-SC meeting
Milestone
Priority Backlog ...

Comments

@Manishearth
Copy link
Member

As of #5822, we generate DecimalDigitsV1 based off of all numbering systems needed for decimal formatting. It's possible for people to have a different preference; to generate all numbering systems available, or a specific list, when you are generating data in separate pipelines.

We should support this.
@Manishearth Manishearth added this to the Priority Backlog ⟨P3⟩ milestone Nov 15, 2024
@Manishearth Manishearth mentioned this issue Nov 15, 2024
Merged
@sffc
Copy link
Member

sffc commented Nov 15, 2024

In general, this falls under the category of "datagen should support customizing data marker attributes".

@sffc sffc added C-data-infra Component: provider, datagen, fallback, adapters discuss Discuss at a future ICU4X-SC meeting labels Nov 15, 2024
@robertbastian
Copy link
Member

This is very easy to implement, we just need to add an attributes_domain = "numsys" to the marker definitions, then you can filter it in datagen.

@Manishearth Manishearth mentioned this issue Jan 9, 2025
Merged
Manishearth added a commit that referenced this issue Jan 9, 2025
@Manishearth
Add attributes_domain to DecimalDigitsV1 (#5962)
ab5fab7 
Fixes #5824



<!--
Thank you for your pull request to ICU4X!

Reminder: try to use [Conventional
Comments](https://conventionalcomments.org/) to make comments clearer.

Please see
https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for
general
information on contributing to ICU4X.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-data-infra Component: provider, datagen, fallback, adapters discuss Discuss at a future ICU4X-SC meeting
Projects
None yet
Milestone
Priority Backlog ⟨P3⟩
Development

Successfully merging a pull request may close this issue.

Add attributes_domain to DecimalDigitsV1 Manishearth/icu4x
3 participants
@sffc @Manishearth @robertbastian