Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time, DateTime, and ZonedDateTime to timezone component #5961

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Time, DateTime, and ZonedDateTime to timezone component #5961

wants to merge 7 commits into from

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jan 8, 2025 •
edited
Loading

Fixes #5929, #5859

@robertbastian robertbastian changed the title Time, DateTime, and ZonedDateTime to timzone component Time, DateTime, and ZonedDateTime to timezone component Jan 8, 2025
sffc
sffc reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right so far; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc left review comments

@Manishearth Manishearth Awaiting requested review from Manishearth Manishearth will be requested when the pull request is marked ready for review Manishearth is a code owner

@zbraniecki zbraniecki Awaiting requested review from zbraniecki zbraniecki will be requested when the pull request is marked ready for review zbraniecki is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CustomZonedDateTime should be just ZonedDateTime
2 participants
@robertbastian @sffc