Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DataResponse.payload be non-optional #2956

Closed
sffc opened this issue Jan 5, 2023 · 2 comments · Fixed by #5037
Closed

Make DataResponse.payload be non-optional #2956

sffc opened this issue Jan 5, 2023 · 2 comments · Fixed by #5037
Assignees
@robertbastian
Labels
2.0-breaking Changes that are breaking API changes
Milestone
ICU4X 2.0 ⟨P1⟩

Comments

@sffc
Copy link
Member

sffc commented Jan 5, 2023

If the data isn't present, an error should be returned. It's likely we don't need the payload to be an Option.
@sffc sffc added the 2.0-breaking Changes that are breaking API changes label Jan 5, 2023
@sffc sffc added this to the ICU4X 2.0 milestone Jan 5, 2023
@sffc sffc mentioned this issue Jan 5, 2023
Merged
@Manishearth Manishearth moved this to Investigate in icu4x 2.0 Feb 23, 2024
@sffc
Copy link
Member Author

sffc commented Mar 14, 2024

I investigated this; the only case where we set None is in draft PR #4607

@sffc sffc moved this from Investigate to Needs discussion to unblock in icu4x 2.0 Mar 14, 2024
@sffc
Copy link
Member Author

sffc commented Apr 25, 2024

As discussed in #58, we plan to add a can_load function to the DataProvider traits, meaning work can be done on this issue.

@sffc sffc removed their assignment Apr 25, 2024
@sffc sffc moved this from Needs discussion to unblock to Small breakage (defer to end) in icu4x 2.0 Apr 25, 2024
@robertbastian robertbastian self-assigned this Apr 29, 2024
@robertbastian robertbastian mentioned this issue Jun 11, 2024
Merged
robertbastian added a commit that referenced this issue Jun 11, 2024
@robertbastian
Make DataRequest.payload non-optional (#5037)
90727cc 
Fixes #2956
@github-project-automation github-project-automation bot moved this from Small breakage (defer to end) to Done in icu4x 2.0 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertbastian robertbastian

Labels
2.0-breaking Changes that are breaking API changes
Projects
icu4x 2.0
Status: Done
Milestone
ICU4X 2.0 ⟨P1⟩
Development

Successfully merging a pull request may close this issue.

Make DataRequest.payload non-optional robertbastian/icu4x
2 participants
@sffc @robertbastian