-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binary size testing #140
Comments
Sounds good. I can't seem to find the official documentation for the https://www.google.com/books/edition/_/kOiZDwAAQBAJ?hl=en&gbpv=1&pg=PA66&dq=cargo+examples+directory |
With #365 merged, this issue is unblocked. We can test how the size of the |
Questions of a newcomer:
|
The demo files are found in the I imagine the file size should be recorded in a manner similar to how we record performance data (cc @echeran). |
Yes, I expect binary size testing would be similar to performance testing. Ideally, the manifestation of the information would be a dashboard that allows us to notice changes over time. The reason is the same for performance testing -- it is easier to help us determine whether a change in metric value is reasonable through comparison to previous values than it would be assessing the absolute number directly. For dashboards, we have a high-level overview of how the dashboard action works and inline source comments. I think that we could reuse the dashboard, but instead of providing it a performance metric number, we provide it a different number (binary size), and inherit the benefits of the dashboard 'infrastructure' provided by the GH Action. Specifically, this would be providing our own value to the
|
Draft PR: #859 |
…amples compiled into wasm binaries. Set up GHA to build wasm binaries, measure file sizes, push results into benchmark dashboard . Resolves ticket unicode-org#140.
…amples compiled into wasm binaries. Set up GHA to build wasm binaries, measure file sizes, push results into benchmark dashboard . Resolves ticket unicode-org#140. Factor in review feedback.
…amples compiled into wasm binaries. Set up GHA to build wasm binaries, measure file sizes, push results into benchmark dashboard . Resolves ticket unicode-org#140. Factor in review feedback. Fix tidy clippy findings.
…amples compiled into wasm binaries (#871) Set up GHA to build wasm binaries, measure file sizes, push results into benchmark dashboard . Resolves ticket #140. Co-authored-by: Greg Tatum <[email protected]> Co-authored-by: Greg Tatum <[email protected]>
In each component, we should have a set of demo files that illustrate common use patterns. We should then compile those demo files with optimizations for code size (
-s
), and have a test that reports their sizes and complains if they grow.I suggest building the demo files to WebAssembly and checking the size of the output .wasm file, because:
The text was updated successfully, but these errors were encountered: