Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add binaries for portable linux build of 126.0.6478.182-1 #564

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

clickot
Copy link
Contributor

@clickot clickot commented Jul 18, 2024

No description provided.

@clickot clickot requested a review from a team as a code owner July 18, 2024 12:27
@clickot
Copy link
Contributor Author

clickot commented Jul 18, 2024

as far as i can see site generation fails because of missing version class in package pkg_resources and has nothing to do with my config files, so I don't know how to fix this. Afaik these classes have been removed in newer versions of the pkg_resoures package

@PF4Public
Copy link

Would it be safe to merge your PR, could we break something then?

@clickot
Copy link
Contributor Author

clickot commented Jul 18, 2024

I fixed the problem by replacing usage of 'version' class from deprecated 'pkg_resources' package with version class from newer 'packaging' package in the sitegenerator.py
I suppose all site generations would fail with the current build setting with the old Version class. Maybe the python version is newer now in the current builder image?

@PF4Public
Copy link

Looks good now, oder isn't it?

@clickot clickot merged commit 2b6eef2 into ungoogled-software:master Jul 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants