Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the requirement for CMS? #88

Open
Taitava opened this issue Jun 6, 2018 · 1 comment
Open

Drop the requirement for CMS? #88

Taitava opened this issue Jun 6, 2018 · 1 comment

Comments

@Taitava
Copy link
Contributor

Taitava commented Jun 6, 2018

Hi,

could it be possible to remove CMS from the dependencies in composer.json? I would like to use this module in a project that does not need a CMS at all. Now I'm using it and removing all the CMS related buttons from the backend, but it feels a little unnecessary to have the cms module installed when it's not needed. :)

This module has a few DashboardPanels that are related to the CMS module, so perhaps those classes could be wrapped with something like this:

if (class_exists('CMSMain') {
    class DashboardRecentEditsPanel extends DashboardPanel {
        ...
    }
}

Would there be any other changes needed? I think I could make a PR if you are interested in this.

Thanks!

@Taitava
Copy link
Contributor Author

Taitava commented Jun 6, 2018

Just for record: I just noticed that @NobrainerWeb has done removing just the dependency from composer.json in his own fork. But this does not include disabling the CMS dependent DashboardPanel classes. I guess it works as long as no user tries to create one of those panels :).

But anyway, I would still be interested to have a more complete solution for this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant