Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer deps need updating for 3.2 #65

Open
dhensby opened this issue Oct 29, 2015 · 8 comments
Open

Composer deps need updating for 3.2 #65

dhensby opened this issue Oct 29, 2015 · 8 comments

Comments

@dhensby
Copy link

dhensby commented Oct 29, 2015

Is there a requirements for CMS at all with this module or does it just rely on framework/admin?

SiteConfig is a dependency and should be listed.

@unclecheese
Copy link
Owner

That's a really good question. I don't know. Have you tried it with a headless framework?

@dhensby
Copy link
Author

dhensby commented Nov 18, 2015

I just did a quick test and it appears to "work" but some of the default widgets depend on SiteTree (recent edits, for example).

Is there a way to just wrap them in if (class_exists('SiteTree')) so they don't appear if you don't have the SiteTree?

v3.2.1 sans CMS

@unclecheese
Copy link
Owner

Yeah, that sounds like the simplest solution. Otherwise, we could break it off into two modules -- dashboard-core and dashboard-cms (with a dependency on the former).

There's a DashboardBlogEntryPanel in the core. That's even more presumptive than SiteTree!

@nedmas
Copy link
Contributor

nedmas commented Dec 22, 2015

Love this module and the idea of slimming down it's dependancies sounds great. However is there any chance that in the mean time you could release an update that allows use in SS 3.2 (with dependancy on framework, cms, and siteconfig)?

@unclecheese
Copy link
Owner

It's set to ~3.1.. that should allow minor release upgrades, right?

@unclecheese
Copy link
Owner

Ah, maybe not. I think that should be ^3.1.

@dhensby
Copy link
Author

dhensby commented Jan 5, 2016

~3.1 should allow 3.2 to work too or you can use ^3.1.1

@dhensby
Copy link
Author

dhensby commented Jan 5, 2016

I think I tested the updating of canView checking for SiteTree and it did work... should get round to a PR some time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants